Bruce/bp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollback '..' optimization because it incorrectly skips ahead multiple

Browse Source 
lines
This commit is contained in:
Bruce Hill 2024-06-16 14:58:19 -04:00
parent 46c2edd4d1
commit 22015bf6ac
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
match.c
View File

@ -446,22 +446,6 @@ static bp_match_t *match(match_ctx_t *ctx, const char *str, bp_pat_t *pat)
return m;
}
// Optimization: for simple cases like `.."foo"` we can speed things up
// by skipping ahead to strstr(str, "foo")
if (!skip) {
bp_pat_t *prereq = get_prerequisite(ctx, target);
if (prereq->type == BP_STRING && prereq->min_matchlen > 0) {
char *found = ctx->ignorecase ?
strcasestr(str, When(prereq, BP_STRING)->string)
: memmem(str, (size_t)(ctx->end - str), When(prereq, BP_STRING)->string, prereq->min_matchlen);
str = found ? found : ctx->end;
} else if (prereq->type == BP_END_OF_FILE) {
str = ctx->end;
} else if (prereq->type == BP_END_OF_LINE) {
str += strcspn(str, "\n\r");
}
}
size_t child_cap = 0, nchildren = 0;
for (const char *prev = NULL; prev < str; ) {
prev = str;