Made escape sequence handling stricter: no longer supporting arbitrary

characters, only special escapes like \n, hex sequences like \x0a, octal
sequences like \012, and backslashes \\
This commit is contained in:
Bruce Hill 2021-07-19 19:57:59 -07:00
parent 711fe47a7f
commit cc84c3d791
5 changed files with 20 additions and 12 deletions

4
bp.1
View File

@ -95,8 +95,8 @@ with one or two patterns.
\f[B]bp\f[R] is designed around this fact.
The default mode for bp patterns is \[lq]string pattern mode\[rq].
In string pattern mode, all characters are interpreted literally except
for the backslash (\f[B]\[rs]\f[R]), which may be followed by a bp
pattern (see the \f[B]PATTERNS\f[R] section below).
for the backslash (\f[B]\[rs]\f[R]), which may be followed by an escape
or a bp pattern (see the \f[B]PATTERNS\f[R] section below).
Optionally, the bp pattern may be terminated by a semicolon
(\f[B];\f[R]).
.SH PATTERNS

View File

@ -90,8 +90,8 @@ literal strings, or strings that are primarily plain strings, with one or two
patterns. `bp` is designed around this fact. The default mode for bp patterns
is "string pattern mode". In string pattern mode, all characters are
interpreted literally except for the backslash (`\`), which may be followed by
a bp pattern (see the **PATTERNS** section below). Optionally, the bp pattern
may be terminated by a semicolon (`;`).
an escape or a bp pattern (see the **PATTERNS** section below). Optionally, the
bp pattern may be terminated by a semicolon (`;`).
# PATTERNS

View File

@ -306,9 +306,11 @@ static pat_t *_bp_simplepattern(file_t *f, const char *str)
const char *opstart = str;
unsigned char e = (unsigned char)unescapechar(str, &str);
if (str == opstart)
file_err(f, start, str, "This isn't a valid escape sequence.");
if (matchchar(&str, '-')) { // Escape range (e.g. \x00-\xFF)
if (next_char(f, str) != str+1)
file_err(f, start, next_char(f, str), "Sorry, UTF8 escape sequences are not supported.");
file_err(f, start, next_char(f, str), "Sorry, UTF8 escape sequences are not supported in ranges.");
const char *seqstart = str;
unsigned char e2 = (unsigned char)unescapechar(str, &str);
if (str == seqstart)

13
print.c
View File

@ -162,12 +162,15 @@ static void _print_match(FILE *out, printer_t *pr, match_t *m)
}
continue;
}
const char *start = r;
char c = unescapechar(r, &r);
(void)fputc(c, out);
if (c == '\n') {
++line;
pr->needs_line_number = 1;
}
if (r > start) {
(void)fputc(c, out);
if (c == '\n') {
++line;
pr->needs_line_number = 1;
}
} else (void)fputc('\\', out);
continue;
} else if (*r == '\n') {
(void)fputc('\n', out);

View File

@ -88,7 +88,7 @@ char unescapechar(const char *escaped, const char **end)
case 'a': ret = '\a'; break; case 'b': ret = '\b'; break;
case 'n': ret = '\n'; break; case 'r': ret = '\r'; break;
case 't': ret = '\t'; break; case 'v': ret = '\v'; break;
case 'e': ret = '\033'; break;
case 'e': ret = '\033'; break; case '\\': ret = '\\'; break;
case 'x': { // Hex
static const unsigned char hextable[255] = {
['0']=0x10, ['1']=0x1, ['2']=0x2, ['3']=0x3, ['4']=0x4,
@ -114,7 +114,10 @@ char unescapechar(const char *escaped, const char **end)
}
break;
}
default: break;
default: {
if (end) *end = escaped;
return (char)0;
}
}
if (end) *end = &escaped[len];
return (char)ret;