Bruce/nomsu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updated launcher script to use find istead of ls and grep, and to

Browse Source 
use "$(...)" instead of eval "$(...)", as per best practice
recommendations.
This commit is contained in:
Bruce Hill 2018-07-22 15:45:02 -07:00
parent addac10a47
commit 0d4f2e45bc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nomsu
View File

@ -1,15 +1,15 @@
#!/bin/bash
while getopts ':V:L' flag; do
case "${flag}" in
V) VERSION="${OPTARG/./\.}\\b" ;;
V) VERSION=$OPTARG ;;
L) LIST="YES" ;;
esac
done
if [[ $VERSION ]]; then
candidates=$(ls $(dirname $BASH_SOURCE) | grep "^nomsu$VERSION[0-9.]*$")
candidates=$(find $(dirname $BASH_SOURCE) -maxdepth 1 -name "nomsu$VERSION*")
else
candidates=$(ls $(dirname $BASH_SOURCE) | grep "^nomsu[0-9.]\+$")
candidates=$(find $(dirname $BASH_SOURCE) -maxdepth 1 -name "nomsu[0-9]*")
fi
if [[ $LIST ]]; then
@ -18,7 +18,7 @@ if [[ $LIST ]]; then
fi
if [[ $candidates ]]; then
eval $(dirname $BASH_SOURCE)/$(echo "$candidates" | sort -V | tail -n 1) $@
"$(echo "$candidates" | sort -V | tail -n 1)" "$@"
else
echo "Failed to find a Nomsu version matching the regex: \"nomsu$VERSION\""
echo "The versions available are:"