Bruce/tomo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

Fix bug in logic for detecting constant strings

Browse Source
This commit is contained in:
Bruce Hill 2024-09-13 02:02:30 -04:00
parent 94a3714686
commit d094049f81
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
typecheck.c
View File

@ -1359,7 +1359,7 @@ type_t *parse_type_string(env_t *env, const char *str)
PUREFUNC bool is_constant(env_t *env, ast_t *ast)
{
switch (ast->tag) {
case Bool: case Num: case Null: case TextLiteral: return true;
case Bool: case Num: case Null: return true;
case Int: {
auto info = Match(ast, Int);
if (info->bits == IBITS_UNSPECIFIED) {
@ -1373,8 +1373,10 @@ PUREFUNC bool is_constant(env_t *env, ast_t *ast)
auto text = Match(ast, TextJoin);
if (!text->children) return true; // Empty string, OK
if (text->children->next) return false; // Concatenation, not constant
CORD literal = Match(text->children->ast, TextLiteral)->cord;
return is_constant(env, text->children->ast);
}
case TextLiteral: {
CORD literal = Match(ast, TextLiteral)->cord;
CORD_pos i;
#pragma GCC diagnostic ignored "-Wsign-conversion"
CORD_FOR(i, literal) {